Fix oxlint --quiet suppressing errors #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained by the comment in source, --quiet should only suppress warning output.
CodSpeed Performance ReportMerging #1008 will not alter performanceComparing Summary
|
Boshen
approved these changes
Oct 18, 2023
|
Thank you so much @developit! Are you using oxlint somewhere? It would be a great motivational boost if this is the case because I'm not too focused on oxlint lately (I'm working on the transformer right now). |
|
@Boshen yeah, we just switched a massive codebase to it. Sent you a DM on the Vite discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained by the comment in source, --quiet should only suppress warning output.
Please double-check that I haven't done something totally wrong here, I don't know Rust.