Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add more "ban-ts-comment" test cases. #3107

Merged
merged 7 commits into from
Apr 26, 2024

Conversation

woai3c
Copy link
Contributor

@woai3c woai3c commented Apr 26, 2024

#2934

name passed failed
ts-expect-error 14 20
ts-ignore 15 20
ts-nocheck 11 9
ts-check 11 8
total 51 57

@github-actions github-actions bot added the A-linter Area - Linter label Apr 26, 2024
@mysteryven mysteryven self-requested a review April 26, 2024 04:45
@woai3c woai3c force-pushed the feat/ban-ts-comment-add-tests branch from 69dcb5a to 02a13ad Compare April 26, 2024 04:59
Copy link

codspeed-hq bot commented Apr 26, 2024

CodSpeed Performance Report

Merging #3107 will not alter performance

Comparing woai3c:feat/ban-ts-comment-add-tests (8ed13f4) with main (bef8a71)

Summary

✅ 30 untouched benchmarks

@woai3c
Copy link
Contributor Author

woai3c commented Apr 26, 2024

I have removed test cases related to emoji. Please review the code again, Thank you. @Boshen @mysteryven

@mysteryven mysteryven merged commit cd600fa into oxc-project:main Apr 26, 2024
33 checks passed
Brooooooklyn referenced this pull request in toeverything/AFFiNE May 7, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [oxlint](https://oxc-project.github.io) ([source](https://togithub.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.3.1` -> `0.3.2`](https://renovatebot.com/diffs/npm/oxlint/0.3.1/0.3.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/oxlint/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/oxlint/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/oxlint/0.3.1/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/oxlint/0.3.1/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>oxc-project/oxc (oxlint)</summary>

### [`v0.3.2`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.2): oxlint v0.3.2

[Compare Source](https://togithub.com/oxc-project/oxc/compare/99d46f9e489663935780f434f52711787ff1de19...a7940868c6e66d16814ebef5c8dbbfd9b948a0cd)

#### What's Changed

[Oxlint Import Plugin Alpha Release](http://localhost:5173/blog/2024-05-04-import-plugin-alpha.html)

-   feat(linter): [@&#8203;typescript-eslint/prefer-literal-enum-member](https://togithub.com/typescript-eslint/prefer-literal-enum-member) by [@&#8203;kaykdm](https://togithub.com/kaykdm) in [https://github.com/oxc-project/oxc/pull/3134](https://togithub.com/oxc-project/oxc/pull/3134)
-   feat(linter): add more "ban-ts-comment" test cases. by [@&#8203;woai3c](https://togithub.com/woai3c) in [https://github.com/oxc-project/oxc/pull/3107](https://togithub.com/oxc-project/oxc/pull/3107)
-   feat(linter): eslint-plugin-jest/require-hook by [@&#8203;eryue0220](https://togithub.com/eryue0220) in [https://github.com/oxc-project/oxc/pull/3110](https://togithub.com/oxc-project/oxc/pull/3110)
-   feat(linter): eslint/no-await-in-loop by [@&#8203;woai3c](https://togithub.com/woai3c) in [https://github.com/oxc-project/oxc/pull/3070](https://togithub.com/oxc-project/oxc/pull/3070)
-   feat(linter): typescript-eslint/prefer-enum-initializers by [@&#8203;todor-a](https://togithub.com/todor-a) in [https://github.com/oxc-project/oxc/pull/3097](https://togithub.com/oxc-project/oxc/pull/3097)
-   feat(linter/jsdoc): Implement `implements-on-classes` rule by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3081](https://togithub.com/oxc-project/oxc/pull/3081)
-   feat(linter/jsdoc): Implement check-tag-names rule by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3029](https://togithub.com/oxc-project/oxc/pull/3029)
-   feat(linter/jsdoc): Implement no-defaults rule by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3098](https://togithub.com/oxc-project/oxc/pull/3098)
-   feat(linter/jsdoc): Implement require-yields rule by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3150](https://togithub.com/oxc-project/oxc/pull/3150)
-   feat(linter/jsdoc): Support settings.ignore(Private|Internal) by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3147](https://togithub.com/oxc-project/oxc/pull/3147)

#### New Contributors

-   [@&#8203;vsn4ik](https://togithub.com/vsn4ik) made their first contribution in [https://github.com/oxc-project/oxc/pull/3118](https://togithub.com/oxc-project/oxc/pull/3118)

**Full Changelog**: oxc-project/oxc@oxlint_v0.3.1...oxlint_v0.3.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5IiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->
@woai3c woai3c deleted the feat/ban-ts-comment-add-tests branch May 17, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants