New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter/jsdoc): Support settings.ignore(Private|Internal) #3147

Merged

Boshen merged 3 commits into main from linter-jsdoc-ignore_settings

May 1, 2024

Collaborator

leaysgur commented May 1, 2024 •

edited

Loading

https://github.com/gajus/eslint-plugin-jsdoc/blob/main/docs/settings.md#user-content-settings-allow-tags-private-or-internal-to-disable-rules-for-that-comment-block

...and fixed the issue that intended initial settings values are not used in some cases.

leaysgur added 2 commits

April 30, 2024 21:55


          feat(linter/jsdoc): Support settings.ignore(Private|Internal)

6fc87b7


          Apply

2fac283

github-actions bot added the A-linter label

codspeed-hq bot commented May 1, 2024 •

edited

Loading

CodSpeed Performance Report

Merging #3147 will not alter performance

_{Comparing linter-jsdoc-ignore_settings (12b14b8) with main (80cf0b2)}

Summary

✅ 30 untouched benchmarks


          Implement default to always enable custom default value

12b14b8

Boshen approved these changes

View reviewed changes

Boshen merged commit d7a8345 into main

33 checks passed

Boshen deleted the linter-jsdoc-ignore_settings branch

May 1, 2024 11:48

Brooooooklyn referenced this pull request in toeverything/AFFiNE


          chore: bump up oxlint version to v0.3.2 (#6763)

0912fe1

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [oxlint](https://oxc-project.github.io) ([source](https://togithub.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.3.1` -> `0.3.2`](https://renovatebot.com/diffs/npm/oxlint/0.3.1/0.3.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/oxlint/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/oxlint/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/oxlint/0.3.1/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/oxlint/0.3.1/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>oxc-project/oxc (oxlint)</summary>

### [`v0.3.2`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.2): oxlint v0.3.2

[Compare Source](https://togithub.com/oxc-project/oxc/compare/99d46f9e489663935780f434f52711787ff1de19...a7940868c6e66d16814ebef5c8dbbfd9b948a0cd)

#### What's Changed

[Oxlint Import Plugin Alpha Release](http://localhost:5173/blog/2024-05-04-import-plugin-alpha.html)

-   feat(linter): [@&#8203;typescript-eslint/prefer-literal-enum-member](https://togithub.com/typescript-eslint/prefer-literal-enum-member) by [@&#8203;kaykdm](https://togithub.com/kaykdm) in [https://github.com/oxc-project/oxc/pull/3134](https://togithub.com/oxc-project/oxc/pull/3134)
-   feat(linter): add more "ban-ts-comment" test cases. by [@&#8203;woai3c](https://togithub.com/woai3c) in [https://github.com/oxc-project/oxc/pull/3107](https://togithub.com/oxc-project/oxc/pull/3107)
-   feat(linter): eslint-plugin-jest/require-hook by [@&#8203;eryue0220](https://togithub.com/eryue0220) in [https://github.com/oxc-project/oxc/pull/3110](https://togithub.com/oxc-project/oxc/pull/3110)
-   feat(linter): eslint/no-await-in-loop by [@&#8203;woai3c](https://togithub.com/woai3c) in [https://github.com/oxc-project/oxc/pull/3070](https://togithub.com/oxc-project/oxc/pull/3070)
-   feat(linter): typescript-eslint/prefer-enum-initializers by [@&#8203;todor-a](https://togithub.com/todor-a) in [https://github.com/oxc-project/oxc/pull/3097](https://togithub.com/oxc-project/oxc/pull/3097)
-   feat(linter/jsdoc): Implement `implements-on-classes` rule by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3081](https://togithub.com/oxc-project/oxc/pull/3081)
-   feat(linter/jsdoc): Implement check-tag-names rule by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3029](https://togithub.com/oxc-project/oxc/pull/3029)
-   feat(linter/jsdoc): Implement no-defaults rule by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3098](https://togithub.com/oxc-project/oxc/pull/3098)
-   feat(linter/jsdoc): Implement require-yields rule by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3150](https://togithub.com/oxc-project/oxc/pull/3150)
-   feat(linter/jsdoc): Support settings.ignore(Private|Internal) by [@&#8203;leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3147](https://togithub.com/oxc-project/oxc/pull/3147)

#### New Contributors

-   [@&#8203;vsn4ik](https://togithub.com/vsn4ik) made their first contribution in [https://github.com/oxc-project/oxc/pull/3118](https://togithub.com/oxc-project/oxc/pull/3118)

**Full Changelog**: oxc-project/oxc@oxlint_v0.3.1...oxlint_v0.3.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5IiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels