refactor(transformer): combine import and usage in JSX transform #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Jun 5, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #3540 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
06-05-improve_transformer_validate_jsx_import_source_option
branch
from
1027b90
to
cbd7c10
Compare
overlookmotel
force-pushed
the
06-05-refactor_transformer_combine_import_and_usage_in_jsx_transform
branch
from
59c75b5
to
6271438
Compare
This was referenced Jun 6, 2024
Merge activity
|
React JSX transform contains some confusing logic (ported directly from Babel) where in automatic mode, imports are inserted in one place, and then used in another. Logic for which imports are needed is duplicated in both places, and it's hard to figure out whether they're in sync or not (I don't think they are in all cases). This PR unifies the logic in one place. Imports are now added as and when they're used. The `Bindings` enum is responsible for creating imports and also holds the state of which "mode" the plugin is working in: 1. Classic 2. Automatic script 3. Automatic module Combining the two choices classic/automatic and script/module into a single enum: 1. clarifies the logic 2. reduces branching 3. reduces lookups on `ReactJsx::options` (which is behind an `Rc` and therefore costly to read from).
Dunqing
force-pushed
the
06-05-improve_transformer_validate_jsx_import_source_option
branch
from
cbd7c10
to
4586f0b
Compare
Dunqing
force-pushed
the
06-05-refactor_transformer_combine_import_and_usage_in_jsx_transform
branch
from
6271438
to
73b7864
Compare
Dunqing
changed the base branch from
06-05-improve_transformer_validate_jsx_import_source_option
to
main
graphite-app
bot
deleted the
06-05-refactor_transformer_combine_import_and_usage_in_jsx_transform
branch
This was referenced Jun 6, 2024
Closed
Closed
Merged
Boshen
added a commit
that referenced
this pull request
Jun 7, 2024
## [0.13.4] - 2024-06-07 ### Features - 5c8e16c coverage: Second transformer build does not print typescript (#3561) (Dunqing) - 646b993 coverage/transformer: Handle @jsx option (#3553) (Dunqing) - a939ddd transformer/typescript: Remove more typescript ast nodes (#3563) (Dunqing) - e8a20f8 transformer/typescript: Remove typescript ast nodes (#3559) (Dunqing) - ee9a215 transformer/typescript: Handle namespace directive correctly (#3532) (Dunqing) ### Bug Fixes - affb2c8 codegen: Print indentation before directive (#3512) (Dunqing) - f6939cb transformer: Store `react_importer` in `Bindings` in JSX transform (#3551) (overlookmotel) - 7982b93 transformer: Correct spans for JSX transform (#3549) (overlookmotel) - c00598b transformer: JSX set `reference_id` on refs to imports (#3524) (overlookmotel) ### Performance - 37cdc13 transformer: Faster checks if JSX plugin enabled (#3577) (overlookmotel) - 9f467b8 transformer: Avoid fragment update where possible (#3535) (overlookmotel) - ac394f0 transformer: JSX parse pragma only once (#3534) (overlookmotel) ### Documentation - 1d3c0d7 span: Add doc comments to `oxc_span::Span` (#3543) (Don Isaac) ### Refactor - f2113ae transformer: Reduce cloning and referencing `Rc`s (#3576) (overlookmotel) - 0948124 transformer: Pass `Rc`s by value (#3550) (overlookmotel) - e4d74ac transformer: Remove `update_fragment` from JSX transform (#3541) (overlookmotel) - 73b7864 transformer: Combine import and usage in JSX transform (#3540) (overlookmotel) - 6978269 transformer/typescript: Replace reference collector with symbols references (#3533) (Dunqing) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React JSX transform contains some confusing logic (ported directly from Babel) where in automatic mode, imports are inserted in one place, and then used in another.
Logic for which imports are needed is duplicated in both places, and it's hard to figure out whether they're in sync or not (I don't think they are in all cases).
This PR unifies the logic in one place. Imports are now added as and when they're used.
The
Bindingsenum is responsible for creating imports and also holds the state of which "mode" the plugin is working in:Combining the two choices classic/automatic and script/module into a single enum:
ReactJsx::options(which is behind anRcand therefore costly to read from).