Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer/typescript): remove more typescript ast nodes #3563

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jun 6, 2024

Remove more TypeScript related AST

Copy link

graphite-app bot commented Jun 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Jun 6, 2024
@Dunqing Dunqing marked this pull request as ready for review June 6, 2024 11:44
Copy link
Member Author

Dunqing commented Jun 6, 2024

Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #3563 will not alter performance

Comparing 06-06-feat_transformer_typescript_remove_more_typescript_ast_nodes (a939ddd) with main (e8a20f8)

Summary

✅ 22 untouched benchmarks

@Dunqing Dunqing force-pushed the 06-06-feat_coverage_second_transformer_build_does_not_print_typescript branch from 78d4c88 to 98a5b03 Compare June 6, 2024 11:56
@Dunqing Dunqing force-pushed the 06-06-feat_transformer_typescript_remove_more_typescript_ast_nodes branch from b6fcc6c to 95bd88e Compare June 6, 2024 11:56
Copy link

graphite-app bot commented Jun 6, 2024

Merge activity

@Boshen Boshen force-pushed the 06-06-feat_coverage_second_transformer_build_does_not_print_typescript branch from 98a5b03 to fa67c9f Compare June 6, 2024 12:20
Boshen pushed a commit that referenced this pull request Jun 6, 2024
@Boshen Boshen force-pushed the 06-06-feat_transformer_typescript_remove_more_typescript_ast_nodes branch from 95bd88e to f5cfa79 Compare June 6, 2024 12:21
@Boshen Boshen force-pushed the 06-06-feat_coverage_second_transformer_build_does_not_print_typescript branch from fa67c9f to 7ed6080 Compare June 6, 2024 12:26
Boshen pushed a commit that referenced this pull request Jun 6, 2024
@Boshen Boshen force-pushed the 06-06-feat_transformer_typescript_remove_more_typescript_ast_nodes branch from f5cfa79 to 8db76c2 Compare June 6, 2024 12:26
@Dunqing Dunqing force-pushed the 06-06-feat_coverage_second_transformer_build_does_not_print_typescript branch from 7ed6080 to 5c8e16c Compare June 7, 2024 05:05
@Dunqing Dunqing force-pushed the 06-06-feat_transformer_typescript_remove_more_typescript_ast_nodes branch from 8db76c2 to a939ddd Compare June 7, 2024 05:05
@Dunqing Dunqing changed the base branch from 06-06-feat_coverage_second_transformer_build_does_not_print_typescript to main June 7, 2024 05:09
@graphite-app graphite-app bot merged commit a939ddd into main Jun 7, 2024
20 checks passed
@graphite-app graphite-app bot deleted the 06-06-feat_transformer_typescript_remove_more_typescript_ast_nodes branch June 7, 2024 05:10
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Boshen added a commit that referenced this pull request Jun 7, 2024
## [0.13.4] - 2024-06-07

### Features

- 5c8e16c coverage: Second transformer build does not print typescript
(#3561) (Dunqing)
- 646b993 coverage/transformer: Handle @jsx option (#3553) (Dunqing)
- a939ddd transformer/typescript: Remove more typescript ast nodes
(#3563) (Dunqing)
- e8a20f8 transformer/typescript: Remove typescript ast nodes (#3559)
(Dunqing)
- ee9a215 transformer/typescript: Handle namespace directive correctly
(#3532) (Dunqing)

### Bug Fixes

- affb2c8 codegen: Print indentation before directive (#3512) (Dunqing)
- f6939cb transformer: Store `react_importer` in `Bindings` in JSX
transform (#3551) (overlookmotel)
- 7982b93 transformer: Correct spans for JSX transform (#3549)
(overlookmotel)
- c00598b transformer: JSX set `reference_id` on refs to imports (#3524)
(overlookmotel)

### Performance

- 37cdc13 transformer: Faster checks if JSX plugin enabled (#3577)
(overlookmotel)
- 9f467b8 transformer: Avoid fragment update where possible (#3535)
(overlookmotel)
- ac394f0 transformer: JSX parse pragma only once (#3534)
(overlookmotel)

### Documentation

- 1d3c0d7 span: Add doc comments to `oxc_span::Span` (#3543) (Don Isaac)

### Refactor

- f2113ae transformer: Reduce cloning and referencing `Rc`s (#3576)
(overlookmotel)
- 0948124 transformer: Pass `Rc`s by value (#3550) (overlookmotel)
- e4d74ac transformer: Remove `update_fragment` from JSX transform
(#3541) (overlookmotel)
- 73b7864 transformer: Combine import and usage in JSX transform (#3540)
(overlookmotel)
- 6978269 transformer/typescript: Replace reference collector with
symbols references (#3533) (Dunqing)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant