-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transformer/typescript): handle namespace directive correctly #3532
feat(transformer/typescript): handle namespace directive correctly #3532
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #3532 will not alter performanceComparing Summary
|
473c45f
to
bf16aa2
Compare
Merge activity
|
bf16aa2
to
ee9a215
Compare
The TS compiler test case this fixed is // @sourcemap: true
module Foo.Bar {
"use strict";
class Greeter {
constructor(public greeting: string) {
}
greet() {
return "<h1>" + this.greeting + "</h1>";
}
}
function foo(greeting: string): Greeter {
return new Greeter(greeting);
}
var greeter = new Greeter("Hello, world!");
var str = greeter.greet();
function foo2(greeting: string, ...restGreetings /* more greeting */: string[]) {
var greeters: Greeter[] = []; /* inline block comment */
greeters[0] = new Greeter(greeting);
for (var i = 0; i < restGreetings.length; i++) {
greeters.push(new Greeter(restGreetings[i]));
}
return greeters;
}
var b = foo2("Hello", "World", "!");
// This is simple signle line comment
for (var j = 0; j < b.length; j++) {
b[j].greet();
}
} |
## [0.13.4] - 2024-06-07 ### Features - 5c8e16c coverage: Second transformer build does not print typescript (#3561) (Dunqing) - 646b993 coverage/transformer: Handle @jsx option (#3553) (Dunqing) - a939ddd transformer/typescript: Remove more typescript ast nodes (#3563) (Dunqing) - e8a20f8 transformer/typescript: Remove typescript ast nodes (#3559) (Dunqing) - ee9a215 transformer/typescript: Handle namespace directive correctly (#3532) (Dunqing) ### Bug Fixes - affb2c8 codegen: Print indentation before directive (#3512) (Dunqing) - f6939cb transformer: Store `react_importer` in `Bindings` in JSX transform (#3551) (overlookmotel) - 7982b93 transformer: Correct spans for JSX transform (#3549) (overlookmotel) - c00598b transformer: JSX set `reference_id` on refs to imports (#3524) (overlookmotel) ### Performance - 37cdc13 transformer: Faster checks if JSX plugin enabled (#3577) (overlookmotel) - 9f467b8 transformer: Avoid fragment update where possible (#3535) (overlookmotel) - ac394f0 transformer: JSX parse pragma only once (#3534) (overlookmotel) ### Documentation - 1d3c0d7 span: Add doc comments to `oxc_span::Span` (#3543) (Don Isaac) ### Refactor - f2113ae transformer: Reduce cloning and referencing `Rc`s (#3576) (overlookmotel) - 0948124 transformer: Pass `Rc`s by value (#3550) (overlookmotel) - e4d74ac transformer: Remove `update_fragment` from JSX transform (#3541) (overlookmotel) - 73b7864 transformer: Combine import and usage in JSX transform (#3540) (overlookmotel) - 6978269 transformer/typescript: Replace reference collector with symbols references (#3533) (Dunqing) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
No description provided.