Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(napi): add tracing via OXC_LOG:DEBUG #202

Merged
merged 1 commit into from
Jun 30, 2024
Merged

feat(napi): add tracing via OXC_LOG:DEBUG #202

merged 1 commit into from
Jun 30, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jun 30, 2024

No description provided.

Copy link

codspeed-hq bot commented Jun 30, 2024

CodSpeed Performance Report

Merging #202 will not alter performance

Comparing tracing (5396d38) with main (1920b55)

Summary

✅ 2 untouched benchmarks

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.84%. Comparing base (1920b55) to head (5396d38).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files          11       11           
  Lines        2284     2284           
=======================================
  Hits         2212     2212           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen merged commit 2551871 into main Jun 30, 2024
21 checks passed
@Boshen Boshen deleted the tracing branch June 30, 2024 15:37
@ematipico
Copy link
Collaborator

Just a nitpick: DEBUG can imply that there might be other levels of logging. Do you plan to add them?

@Boshen
Copy link
Member Author

Boshen commented Jun 30, 2024

Just a nitpick: DEBUG can imply that there might be other levels of logging. Do you plan to add them?

I may add other INFO logs when the current information is insufficient for complicated situations.

@Boshen
Copy link
Member Author

Boshen commented Jun 30, 2024

Oh, I see a trace here tracing::trace!(tsconfig = ?tsconfig, "load_tsconfig"); 😅

@ematipico
Copy link
Collaborator

It's actually the other way around. Info gives less information, and trace gives more information than debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants