Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: add symlink fixtures #219

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

Brooooooklyn
Copy link
Member

No description provided.

Copy link
Member Author

Brooooooklyn commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Jul 9, 2024

CodSpeed Performance Report

Merging #219 will not alter performance

Comparing 07-09-bench_add_symlink_fixtures (1013c5e) with main (176dc45)

Summary

✅ 2 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main 07-09-bench_add_symlink_fixtures Change
🆕 resolver[resolve from symlinks] N/A 67.2 ms N/A

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (176dc45) to head (1013c5e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          11       11           
  Lines        2306     2306           
=======================================
  Hits         2235     2235           
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn force-pushed the 07-09-bench_add_symlink_fixtures branch from 4a78c0d to a94a984 Compare July 9, 2024 14:41
@Boshen
Copy link
Member

Boshen commented Jul 9, 2024

We need another benchmark set where it doesn't reuse the cache.

@Brooooooklyn Brooooooklyn force-pushed the 07-09-bench_add_symlink_fixtures branch 2 times, most recently from f77fa0b to 8013161 Compare July 10, 2024 05:54
@Brooooooklyn Brooooooklyn force-pushed the 07-09-bench_add_symlink_fixtures branch from 8013161 to 1013c5e Compare July 10, 2024 06:26
@Boshen
Copy link
Member

Boshen commented Jul 10, 2024

codspeed doesn't measure any syscalls, but this button is not showing anything either

image

@Brooooooklyn
Copy link
Member Author

@Boshen I can see performance changes on my macOS:

CleanShot 2024-07-10 at 14 32 07@2x

@Brooooooklyn Brooooooklyn requested a review from Boshen July 10, 2024 07:31
Copy link
Member

Boshen commented Jul 10, 2024

Merge activity

  • Jul 10, 10:33 AM EDT: @Boshen started a stack merge that includes this pull request via Graphite.
  • Jul 10, 10:33 AM EDT: @Boshen merged this pull request with Graphite.

@Boshen Boshen merged commit e29975d into main Jul 10, 2024
22 checks passed
@Boshen Boshen deleted the 07-09-bench_add_symlink_fixtures branch July 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants