Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve module ipaddr.js correctly when extensionAlias is provided #228

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jul 15, 2024

closes #227

Managed to figure this out after stepping through https://github.com/webpack/enhanced-resolve/blob/main/lib/ExtensionAliasPlugin.js

Copy link

codspeed-hq bot commented Jul 15, 2024

CodSpeed Performance Report

Merging #228 will not alter performance

Comparing fix-extension-alias (f8ff397) with main (312d612)

Summary

✅ 3 untouched benchmarks

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (312d612) to head (f8ff397).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   96.95%   96.97%   +0.01%     
==========================================
  Files          11       11              
  Lines        2297     2312      +15     
==========================================
+ Hits         2227     2242      +15     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen merged commit 5644abb into main Jul 15, 2024
21 checks passed
@Boshen Boshen deleted the fix-extension-alias branch July 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant