Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user to delete unsent messages #2953

Closed
wants to merge 1 commit into from

Conversation

KeeJef
Copy link
Collaborator

@KeeJef KeeJef commented Oct 9, 2023

This is a proxy pull request from the following codeberg branch, https://codeberg.org/gravel/session-desktop/commits/branch/delete-unsent-messages

Messages sent to open groups can fail to send.

However, users are unable to delete unsent open group messages,
as the 'Delete for everyone' option mandates that
open group messages must be deleted from the server
before being deleted locally, and no other delete option is shown.
Furthermore, in open groups, the 'Delete just for me' option
fails to trigger a distinct code path from 'Delete for everyone'.

This commit enables the 'Delete just for me' context menu option
for all outgoing messages with status 'error'.
To direct the user to the appropriate action,
this commit also hides the 'Delete for everyone' option
for the same messages. Lastly, it also implements the missing
'Delete for me' functionality for open group messages.

Relates: #2745

@burtonemily
Copy link
Collaborator

Looks good 👌

@Bilb Bilb changed the base branch from clearnet to unstable March 27, 2024 06:20
@Bilb
Copy link
Collaborator

Bilb commented Mar 27, 2024

closing this in favor of #3061

@Bilb Bilb closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants