forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete failed outgoing messages for communities #3061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: confirm modal when enter is pressed fix: fix linter issues fix: update rebase and fix lint issues fix: remove duplicate code
the focustrap on the selection overlay will grab the keys and do the acitons when it is mounted
yougotwill
requested changes
Mar 28, 2024
Bilb
force-pushed
the
delete-failed-outgoing-messages
branch
from
March 28, 2024 02:46
e6e4e94
to
3a1b811
Compare
yougotwill
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for QA! 🕵️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2953
Note: To be merge after #2977
Made a new as we needed to make one on top of #2977
I believe all we want here is to allow to delete locally messages which failed to be sent in a sogs community, and that should now been taken care of