Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove app setting password protection #2954

Closed
wants to merge 4 commits into from
Closed

feat: remove app setting password protection #2954

wants to merge 4 commits into from

Commits on Oct 9, 2023

  1. feat: remove app setting password protection 

    Most app settings are less sensitive
than the content of one's messages,
and therefore do not require password protection.

This commit removes password protection from
the settings view. This also dampens the UX impact
of the misleading 'Message Requests' entry among
settings categories, as the settings view
is closed and locked upon navigation to the entry.

Sensitive app settings are addressed in later commits.

Relates: oxen-io#1768
    @KeeJef
    gravel authored and KeeJef committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2f6bf2e View commit details
    Browse the repository at this point in the history

  2. refactor: decouple password modal from seed phrase 

    As we may want to password-protect other settings categories,
it is crucial to seperate the password protection modal
from the seed phrase modal, where it was previously bound.
    @KeeJef
    gravel authored and KeeJef committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0ae8935 View commit details
    Browse the repository at this point in the history

  3. refactor: split account deletion modal

    @KeeJef
    gravel authored and KeeJef committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1590f1f View commit details
    Browse the repository at this point in the history

  4. feat: password-protect account deletion

    @KeeJef
    gravel authored and KeeJef committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7a8d60b View commit details
    Browse the repository at this point in the history