Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TezosK8sHelmChart config property should only be a subset of properties #10

Closed
harryttd opened this issue Dec 14, 2021 · 0 comments · Fixed by #11
Closed

TezosK8sHelmChart config property should only be a subset of properties #10

harryttd opened this issue Dec 14, 2021 · 0 comments · Fixed by #11
Assignees
@harryttd

Comments

@harryttd
Copy link
Collaborator

The type of TezosK8sHelmChart.config is pulumi Helm chart config's type ChartOpts | LocalChartOpts. This type is the input properties for a pulumi Helm chart component. This should not be the value of .config on our component. It only needs to be a subset of properties, such as values which is an object of the values that will be applied to the chart. config shouldn't be exposing fields such as skipCRDRendering rendering.
@harryttd harryttd self-assigned this Dec 14, 2021
@harryttd harryttd mentioned this issue Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harryttd harryttd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc updates oxheadalpha/tezos-pulumi
1 participant
@harryttd