Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32h7-i2c chooses timing based on SoC model, not board #242

Open
cbiffle opened this issue Nov 3, 2021 · 0 comments
Open

stm32h7-i2c chooses timing based on SoC model, not board #242

cbiffle opened this issue Nov 3, 2021 · 0 comments
Labels
stm32 Has specific implications for STM32 processors

Comments

@cbiffle
Copy link
Collaborator

cbiffle commented Nov 3, 2021

The current configure_timing routine in stm32h7-i2c assumes that any board with a given SoC model has the same clock configuration.

fn configure_timing(&self, i2c: &RegisterBlock) {

Knowledge of clocks should probably move out of this crate to the caller, who should decide it based on target_board instead.

FYI @bcantrill

@cbiffle cbiffle added the stm32 Has specific implications for STM32 processors label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stm32 Has specific implications for STM32 processors
Projects
None yet
Development

No branches or pull requests

1 participant