Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Windows #6

Merged
merged 2 commits into from Oct 6, 2019
Merged

Add support for Windows #6

merged 2 commits into from Oct 6, 2019

Commits on Oct 6, 2019

  1. Fix crash on Windows 

    - The `which` utility doesn't exist on Windows which leads to a
  FileNotFoundError when trying to look up the path of the Python
  binary. This change adds a fallback to `sys.executable` [1] which
  fixes the problem (as long as we can assume that the Python
  interpreter used to run flask-now is a valid Python3 interpreter).

- The path to the pip executable in a virtual environment is different
  on Windows than Unix which leads to a FileNotFoundError. This change
  adds a check to `os.name` [2] to adjust the pip path if flask-now is
  being run on Windows.

[1] https://docs.python.org/3/library/sys.html#sys.executable
[2] https://docs.python.org/3/library/os.html#os.name
    @c-w
    c-w committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    763cba8 View commit details
    Browse the repository at this point in the history

  2. Use sys.executable on all platforms

    @c-w
    c-w committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    f1bfdbc View commit details
    Browse the repository at this point in the history