Add support for Windows#6
Merged
ozanonurtek merged 2 commits intoozanonurtek:masterfrom Oct 6, 2019
c-w:windows-support
Merged
Add support for Windows#6ozanonurtek merged 2 commits intoozanonurtek:masterfrom c-w:windows-support
ozanonurtek merged 2 commits intoozanonurtek:masterfrom
c-w:windows-support
Conversation
- The `which` utility doesn't exist on Windows which leads to a FileNotFoundError when trying to look up the path of the Python binary. This change adds a fallback to `sys.executable` [1] which fixes the problem (as long as we can assume that the Python interpreter used to run flask-now is a valid Python3 interpreter). - The path to the pip executable in a virtual environment is different on Windows than Unix which leads to a FileNotFoundError. This change adds a check to `os.name` [2] to adjust the pip path if flask-now is being run on Windows. [1] https://docs.python.org/3/library/sys.html#sys.executable [2] https://docs.python.org/3/library/os.html#os.name
Owner
|
Thanks for your contribution and opening this pull request,
|
ozanonurtek
requested changes
Oct 6, 2019
Owner
ozanonurtek
left a comment
ozanonurtek
left a comment
There was a problem hiding this comment.
As I mentioned before, sys.executable also works fine with MacOS and GNU/Linux. So could you please refactor your contribution in that way 😸
Contributor
Author
|
Thanks for the review @ozanonurtek. Made the change to always use |
ozanonurtek
approved these changes
Oct 6, 2019
Owner
|
This will be packed tomorrow with version 0.2.2. @c-w, thanks for the change! |
Owner
|
Released under 0.2.2. I was a bit busy, sorry for latency. Thanks for your all support @c-w 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes flask-now work on Windows.
This required two minor fixes:
The
whichutility doesn't exist on Windows which leads to a FileNotFoundError when trying to look up the path of the Python binary. This change adds a fallback to sys.executable which fixes the problem (as long as we can assume that the Python interpreter used to run flask-now is a valid Python3 interpreter).The path to the pip executable in a virtual environment is different on Windows than Unix which leads to a FileNotFoundError. This change adds a check to os.name to adjust the pip path if flask-now is being run on Windows.