-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobs still run after context is done #10
Comments
Do you have some code I can test with? Let's say you have a job that sleeps for 1 hour but your timeout is 1 second. How would you go about cancelling a job that is just sleeping (or in flight)? |
This one is really stumping me.... I reached out to the author of workerpool (gammazero/workerpool#40) for help on this.. I think it is out of my understanding of Go as to why this is happening. You can view a better POC here Any idea how to resolve this? |
HI, I saw that you got a nice answer which solve the problem :-) , when to expect to new version as we want to run it on prod. Thanks! |
@BredSt what makes you think the problem is resovled? |
Hi @oze4 - this replay #7 (comment), but I understand that it a bit tricky :( as the tread continue..., now I saw this gammazero/workerpool#40 (comment) |
HI,
I've some time to run some extended test (on the master branch code ) and I found one issue.:)
in case you provide a
timeout
andretry
to specific task you are getting the error that the time passed which is ok. However, the task is proceed and continue to run which is problematic as the timeout should win.User should define a timeout as limit to the task and after the job exceed the timeout it should be killed to free resources as if it pass the results after the timeout the results is not valid anymore...
as the
jobResults := wp.StopWaitXT()
should handle it.WDYT?
The text was updated successfully, but these errors were encountered: