Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdist builds disabled #2

Closed
rjdbcm opened this issue Sep 4, 2023 · 1 comment
Closed

sdist builds disabled #2

rjdbcm opened this issue Sep 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@rjdbcm
Copy link
Member

rjdbcm commented Sep 4, 2023 •
edited
Loading

Describe the bug

Building an sdist in Github CI fails with various permissions issues due to the way we construct wheels. We need to update PKG-INFO for meson dist based sdist build. I thought I would be able to fix this by merging PKG-INFO during the CI build but setuptools_scm still sees changes. I am currently considering that this might be due to the artifact folder not being included into .gitignore.

Now, personally I am fine with defaulting to only wheel releases being published to PyPI as they are built from the git tag/release distribution. Therefore, I am creating this issue for posterity as I am satisfied with the state of OZI being a wheel-only platform.
@rjdbcm rjdbcm added the enhancement New feature or request label Sep 4, 2023
rjdbcm added a commit that referenced this issue Nov 10, 2023
@rjdbcm
🔨👷(GitHub): Fix publish workflow to publish an sdist.
5a059e1 
Fixes sdist builds disabled #2
@rjdbcm
Copy link
Member Author

rjdbcm commented Nov 10, 2023

Fixed in Release 0.0.196

@rjdbcm rjdbcm closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rjdbcm