Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: always creating paging mapping, not file mapping #6

Closed
dimichgh opened this issue May 10, 2016 · 2 comments
Closed

windows: always creating paging mapping, not file mapping #6

dimichgh opened this issue May 10, 2016 · 2 comments

Comments

@dimichgh
Copy link

https://github.com/ozra/mmap-io/blob/master/src/mman.h#L57

Should it be as follows?

HANDLE h = (fd != -1) ? HANDLE(_get_osfhandle(fd)) : INVALID_HANDLE_VALUE;

But anyways, this will still be broken due to this problem: nodejs/node#6369

@ozra
Copy link
Owner

ozra commented May 10, 2016

Better see if @toxicwolf has some input on it. I've been running Linux for 19 years, so I'm lost here B-) PR's are welcome.

@ozra ozra added the bug label May 10, 2016
@dimichgh dimichgh changed the title windows: always created paging mapping, not file mapping windows: always creating paging mapping, not file mapping May 11, 2016
@bkmartinjr bkmartinjr mentioned this issue Dec 22, 2017
@ozra
Copy link
Owner

ozra commented Mar 5, 2018

Fixed via bkmartinjr, #11

@ozra ozra closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants