Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT detection #20

Closed
FranklinYu opened this issue Oct 30, 2017 · 2 comments
Closed

JWT detection #20

FranklinYu opened this issue Oct 30, 2017 · 2 comments
Labels
enhancement

Comments

@FranklinYu
Copy link

FranklinYu commented Oct 30, 2017 •
edited
Loading

Currently if header has Authorization: Bearer it would say "JWT detected" (I believe the logic is here), but RFC 6750 doesn't require Bearer Token to be JWT (for example some Google API doesn't use JWT as Bearer Token). It might be better to label the request as "JWT detected" only when Bearer Token is valid JWT.
ozzi- added a commit that referenced this issue Oct 31, 2017
@ozzi-
cookie flag hints are now shown in all applicable, same for registere…
b7e9250 
…d claims. improved authorization header detection - fixing #20. unit tests!
@ozzi-
Copy link
Owner

ozzi- commented Oct 31, 2017 •
edited
Loading

This should fix the issue, please confirm
https://github.com/mvetsch/JWT4B/blob/2420fb13ca489bbb3f08a8a537f6e906f644fbf1/src/app/tokenposition/AuthorizationBearerHeader.java#L33

Built version with fix:
jwt4b.jar.zip

@FranklinYu
Copy link
Author

Works great! Thank a lot man

@ozzi- ozzi- mentioned this issue Nov 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FranklinYu @ozzi-