Default dimensions option changing

[katoquro]

env:

• Ubuntu quantal (12.10)
• Cinnamon 1.8.8-0ubuntu1~quantal1
• finalterm 0.1-064quantal1

Any change of Default dimensions leads to reducing of window height (even in guake mode) in runtime.

[spamalot]

This happens with kwin (4.10.5) as well.
EDIT: After a bit of looking around, I see a problem. While the lines value is correct in SettingsWindow.vala (line 36), it is incorrect (and decreases) in on_settings_changed (line 415) in FinalTerm.vala.
EDIT 2: The value being set in on_settings_changed is the value set by on_allocation_changed (line 497) in TerminalView.vala. It looks like terminal.lines is not getting set when its setting is changed.

[p-e-w]

This is likely a duplicate of #71.

[spamalot]

It almost certainly is. The main_window.resize at the end of on_settings_changed would make sense as the problem in both issues. Why is this resize necessary anyway?

[rdlu]

Tested on Linux Mint 15
(Ubuntu 13.04; Cinnamon 1.8.8)

Same behavior on finalterm_0.1-080ubuntu13.04.1 from ppa

[p-e-w]

This should be a non-issue after 2a34971.