Complile error

[stiks]

stiks@s:~/finalterm/build$ cmake ..
-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.26")
-- checking for module 'unity'
-- package 'unity' not found
-- checking for module 'libnotify'
-- found libnotify, version 0.7.5
-- checking for modules 'clutter-gtk-1.0;mx-1.0;keybinder-3.0;gee-0.8;libnotify'
-- found clutter-gtk-1.0, version 1.2.0
-- found mx-1.0, version 1.4.6
-- found keybinder-3.0, version 0.2.90
-- found gee-0.8, version 0.8.4
-- found libnotify, version 0.7.5
-- Found Vala: /usr/bin/valac
-- checking for a minimum Vala version of 0.16.0
-- found Vala, version 0.16.1
-- GSettings schemas will be installed locally.
-- GSettings shemas will be compiled.
-- GSettings schemas will be installed into /usr/local/share/glib-2.0/schemas/
-- Configuring done
-- Generating done
-- Build files have been written to: /home/stiks/finalterm/build

stiks@s:~/finalterm/build$ make
[ 5%] Generating src/FinalTerm.c, src/Terminal.c, src/TerminalStream.c, src/TerminalOutput.c, src/CharacterAttributes.c, src/TerminalView.c, src/LineView.c, src/Autocompletion.c, src/NotifyingList.c, src/ScrollableListView.c, src/Utilities.c, src/TextMenu.c, src/ColorScheme.c, src/Theme.c, src/KeyBindings.c, src/Command.c, src/Settings.c, src/Metrics.c, build/src/Config.c
/home/stiks/finalterm/src/LineView.vala:56.3-56.25: error: The name x_expand' does not exist in the context ofClutter.Text'
text_container.x_expand = true;
^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)
make[2]: *** [src/FinalTerm.c] Error 1
make[1]: *** [CMakeFiles/finalterm.dir/all] Error 2
make: *** [all] Error 2

[archkens]

What distro?

[stiks]

Debian, Wheezy

[p-e-w]

Looks like a duplicate of #32. Please verify that you have Clutter 1.12.

[stiks]

stiks@s:~/finalterm/build$ dpkg -l | grep clutter-
iU gir1.2-clutter-1.0 1.14.0-1 amd64 GObject introspection data for the Clutter 1.0 library
ii gir1.2-gtkclutter-1.0 1.2.0-2 amd64 GObject introspection data for the GTK+ Clutter library
ii libclutter-1.0-0:amd64 1.10.8-2 amd64 Open GL based interactive canvas library
iU libclutter-1.0-dev 1.14.0-1 amd64 Open GL based interactive canvas library (development files)
ii libclutter-gtk-1.0-0:amd64 1.2.0-2 amd64 Open GL based interactive canvas library GTK+ widget
ii libclutter-gtk-1.0-dev 1.2.0-2 amd64 Open GL based interactive canvas library GTK+ widget (development files)

It's look like 1.14.0 installed and libclutter 1.10.8

[archkens]

Wasn't x_expand added in clutter 1.14.4?

[p-e-w]

Not according to the docs: https://developer.gnome.org/clutter/1.12/ClutterActor.html#ClutterActor--x-expand says 1.12.

[p-e-w]

And I have 1.12 on my system, and it works for me.

[tom95]

Alternatively the actor.x_expand could be replaced with "(layout_manager as Clutter.BoxLayout).set_expand(actor, true);", which is deprecated, but also works with older Vala/Clutter.

[p-e-w]

@stiks: Could you kindly try whether @TomB95's idea fixes the problem for you? If it does, I'll change that line.

[tom95]

@stiks more precisely that'd be replacing line 56 in src/LineView.vala with "(layout_manager as Clutter.BoxLayout).set_expand(text_container, true);"

[jrabbit]

@p-e-w @TomB95's fix works great on Debian testing. This is still a problem. other than having to compile keybind-3.0 the build on debian is tolerable.

It may be causing this:

[p-e-w]

o_o

[tom95]

@jrabbit Not entirely sure about this, but could you try adding "(layout_manager as Clutter.BoxLayout).set_fill(text_container, true, false);" right below the previous line.

[jrabbit]

diff --git a/src/LineView.vala b/src/LineView.vala
index e1b1a92..18ae947 100644
--- a/src/LineView.vala
+++ b/src/LineView.vala
@@ -49,7 +49,9 @@ public class LineView : Clutter.Actor {
                add(collapse_button);

                text_container = new Clutter.Text();
-               text_container.x_expand = true;
+               //text_container.x_expand = true;
+               (layout_manager as Clutter.BoxLayout).set_expand(text_container, true);
+               (layout_manager as Clutter.BoxLayout).set_fill(text_container, true, false);
                text_container.line_wrap = true;
                text_container.line_wrap_mode = Pango.WrapMode.CHAR;

seems to work fine.

[p-e-w]

Pushed to master. Thank you for the workaround, @TomB95!