Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid original_destination_connection_id #34

Open
QUICTester opened this issue Jul 18, 2023 · 2 comments
Open

Invalid original_destination_connection_id #34

QUICTester opened this issue Jul 18, 2023 · 2 comments

Comments

@QUICTester
Copy link

QUICTester commented Jul 18, 2023 •
edited
Loading

Hi,

During testing commit 841c822, we discovered that the PQUIC server always updates/overwrites its original_destination_connection_id when processing the client's Initial packet.

According to RFC 9000, original_destination_connection_id is the value of the Destination Connection ID field from the first Initial packet sent by the client. However, when sending the packet sequence below, PQUIC will overwrite the value every time it receives a new Initial packet:

  1. Initial packet that carries a Ping frame
  2. Initial packet that carries a Ping frame
@QUICTester QUICTester changed the title Handshake completion without initialClientHello Invalid original_destination_connection_id Sep 4, 2023
@IoniaSpirit IoniaSpirit mentioned this issue Sep 5, 2023
Merged
@mpiraux
Copy link
Member

mpiraux commented Oct 4, 2023

Could you test #39 as a potential fix ?

@QUICTester
Copy link
Author

Yes, it is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpiraux @QUICTester