Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for "Clear history on quit" to not store history on disk #733

Open
2 tasks done
AviKav opened this issue Feb 17, 2024 · 4 comments
Open
2 tasks done

Option for "Clear history on quit" to not store history on disk #733

AviKav opened this issue Feb 17, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@AviKav
Copy link

AviKav commented Feb 17, 2024

Before Submitting Your Feature Request

  • Check that there isn't already a similar feature request to avoid creating a duplicate.
  • I have seen the FAQ.

Problem

Currently Maccy writes history to ~/Library/Containers/org.p0deje.Maccy/Data/Library/Application Support/Maccy/Storage.sqlite stores history when "Clear history on quit" is checkmarked.

Coming from KDE's Klipper, I assumed Maccy would only store history in memory with this option. I didn't really think twice about it until I noticed the wording and decided to double check

Solution

A sub-option for "Clear history on quit" that doesn't write history to disk

@AviKav AviKav added the enhancement New feature or request label Feb 17, 2024
@p0deje
Copy link
Owner

p0deje commented Feb 17, 2024

Thank you for the feedback! This is not something I had on my mind, can you please provide more details about why you'd want this added?

Even though it might be possible to implement this via Core Data, I'm not sure how practical this would be. There are already multiple issues related to memory bloat (#384, #726) and the desire to keep unlimited history (#310) so I wonder how this would complicate the implementation, supporting simultaneously both disk/memory storage backends.

@AviKav
Copy link
Author

AviKav commented Feb 17, 2024

can you please provide more details about why you'd want this added?

Short answer, because when I copy something sensitive into my clipboard I don't want to rely on checking if Maccy has been temporarily disabled

unlimited history

I'd think enabling it would be mutually exclusive with in-memory-only, but maybe not?

so I wonder how this would complicate the implementation, supporting simultaneously both disk/memory storage backends.

I think the most complicated thing would be migrating items between stores and exposing the "when" to users.

There's also the question of what to do about pinned items as there's merits to both persisting and not persisting them

@p0deje
Copy link
Owner

p0deje commented Mar 10, 2024

I generally wouldn't mind supporting that so PRs are welcome, but I won't be able to implement this myself.

@p0deje p0deje added the help wanted Extra attention is needed label Mar 10, 2024
@vietstone-ng
Copy link

vietstone-ng commented Oct 7, 2024

Is this implemented in v2?. I see 2 options in Advanced settings:

  • Clear history on quit
  • Clear the system clipboard too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants