Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Module Conflict with Automated Animations #21

Closed
Brimcon opened this issue Mar 24, 2022 · 5 comments
Closed

[BUG] Module Conflict with Automated Animations #21

Brimcon opened this issue Mar 24, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@Brimcon
Copy link

Brimcon commented Mar 24, 2022

Module Version:
Conditional Visibilty: v0.5.6
Automated Animations version 2.5.6

Describe the bug
With Automated Animations enabled Conditional Visibility prints an error and becomes non-functional.

module.js:44 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'API')
[Detected 1 package: conditional-visibility]
    at setupHooks (module.js:44:34)
    at conditional-visibility.js:41:5
    at Function._call (foundry.js:294:14)
    at Function.callAll (foundry.js:253:12)
    at Game.setupGame (foundry.js:5528:11)
    at Game._initializeGameView (foundry.js:6510:16)
    at Game._initializeView (foundry.js:6486:21)
    at Game.initialize (foundry.js:5433:16)

To Reproduce
Steps to reproduce the behavior:
Enable both Conditional Visibility and Automated Animations alongside their dependancies
Refresh page. Observe Console Error.

Expected behavior
No Console Error and functional Conditional Visibility.

Browser:
Chrome

Foundry Version:
Version 9.255

Game System:
DnD5e 1.5.7

Additional context
CVTest-1648142888547.log

@Brimcon Brimcon added the bug Something isn't working label Mar 24, 2022
@p4535992
Copy link
Owner

Can't replicate this issue, but other peolple show the same error in different use case, try out 0.5.7 and tell me if the error still show up.

@Brimcon
Copy link
Author

Brimcon commented Mar 25, 2022

Still occurs on my end. I am also running on a dedicated remote server, Lemme see if it happens on local server.

@Brimcon
Copy link
Author

Brimcon commented Mar 25, 2022

Confirmed it happens on my local server.
I have an actor on a fresh scene (Human Fighter from Starter Heroes in DnD5e)
After having that actor on the field and hitting refresh prints the error.
image

With the actor removed from the scene the error does not occur on Local, still occurs on Remote.

@Brimcon
Copy link
Author

Brimcon commented Mar 26, 2022

Update on Local server: Refreshing multiple times occasionally brings up the error. Its 100% Consistant on remote, but occurs every 6 or 7 refreshes on Local/Electron

@Brimcon
Copy link
Author

Brimcon commented Mar 26, 2022

Fixed!

@Brimcon Brimcon closed this as completed Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants