Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some comments in test programs regarding recirculate, resubmit, and clone operations in v1model #2977

Closed
jfingerh opened this issue Dec 5, 2021 · 5 comments

Comments

@jfingerh
Copy link

jfingerh commented Dec 5, 2021

At least these test programs have comments that will be obsolete after this PR is merged: #2902

v1model-special-ops-bmv2-first.p4

There may be more. It seems easier to wait until that other (large and complex) PR is merged, then fix up the comments in later commits.

This directory of example P4 programs is not part of any p4lang repo, but would also be good to update, at least to mark many of the programs there as of historical interest only, e.g. move them to an 'old-v1model-style' subdirectory, after PR #2902 is merged: https://github.com/jafingerhut/p4-guide/tree/master/v1model-special-ops

@jfingerh
Copy link
Author

jfingerh commented Dec 5, 2021

This documentation about v1model could also stand some updates after PR #2902 is merged: https://github.com/p4lang/behavioral-model/blob/main/docs/simple_switch.md

@jfingerh
Copy link
Author

jfingerh commented Dec 5, 2021

With these changes, there is no way to put the new @field_list annotation onto a field in any standard/intrinsic metadata structs. This seems like a reasonable restriction for this feature, and we should mention it in other documentation, including a suggested workaround that of course one is welcome to copy a standard metadata field value into a user-defined metadata field, and preserve the user-defined metadata field.

@jafingerhut
Copy link
Contributor

This PR updates documentation of the v1model architecture in the p4lang/behavioral-model repo: p4lang/behavioral-model#1057

@jafingerhut
Copy link
Contributor

This PR updates some comments in v1model.p4 include file and one of the p4c test programs that uses recirculate, resubmit, clone operations: #2985

@jafingerhut
Copy link
Contributor

I have today updated multiples files in this directory of my p4-guide public repo related to recirculate/resubmit/clone and preserving user-defined metadata, too: https://github.com/jafingerhut/p4-guide/tree/master/v1model-special-ops

I am closing this issue. Feel free to open other issues if anyone finds obsolete documentation somewhere regarding these operations, on the repo containing that documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants