Reintroduce UPGRADE_NO_OP env-var to ease 'helm upgrade' auto-restart…

…ing pods to consume new secrets. This is a stop gap until we migrate secrets to volumes, and watch their inodes to restart (#8113) (#8118)
pachyderm · Aug 25, 2022 · 80aee4e · 80aee4e
1 parent 6b423ae
commit 80aee4e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/etc/helm/pachyderm/templates/console/deployment.yaml b/etc/helm/pachyderm/templates/console/deployment.yaml
@@ -88,6 +88,10 @@ spec:
             secretKeyRef:
               name: {{ .Values.console.config.oauthClientSecretSecretName | default "pachyderm-console-secret"}}
               key: OAUTH_CLIENT_SECRET
+        {{- if .Release.IsUpgrade }}
+        - name: UPGRADE_NO_OP
+          value: {{ randAlphaNum 32 }}
+        {{- end }}
         {{- if and .Values.pachd.tls.enabled .Values.global.customCaCerts }}
         - name: NODE_EXTRA_CA_CERTS
           value:  /pach-tls/certs/root.crt

diff --git a/etc/helm/pachyderm/templates/enterprise-server/deployment.yaml b/etc/helm/pachyderm/templates/enterprise-server/deployment.yaml
@@ -180,6 +180,10 @@ spec:
               name: pachyderm-console-secret
               key: OAUTH_CLIENT_SECRET
         {{- end }}
+        {{- if .Release.IsUpgrade }}
+        - name: UPGRADE_NO_OP
+          value: {{ randAlphaNum 32 }}
+        {{- end }}
         envFrom:
           - secretRef:
               name: pachyderm-deployment-id-secret

diff --git a/etc/helm/pachyderm/templates/pachd/deployment.yaml b/etc/helm/pachyderm/templates/pachd/deployment.yaml
@@ -313,6 +313,10 @@ spec:
         - name: IDENTITY_SERVER_DATABASE
           value: {{ .Values.global.postgresql.identityDatabaseFullNameOverride }}
         {{ end }}
+        {{- if .Release.IsUpgrade }}
+        - name: UPGRADE_NO_OP
+          value: {{ randAlphaNum 32 }}
+        {{- end }}
         envFrom:
           - secretRef:
               name: pachyderm-storage-secret