Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce UPGRADE_NO_OP in deployment.yaml #8113

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

acohen4
Copy link
Contributor

@acohen4 acohen4 commented Aug 23, 2022

Reintroduce UPGRADE_NO_OP env-var to ease 'helm upgrade' auto-restarting pods to consume new secrets. This is a stop gap until we migrate secrets to volumes, and watch their inodes to restart

…ing pods to consume new secrets. This is a stop gap until we migrate secrets to volumes, and watch their inodes to restart
@acohen4 acohen4 requested a review from jrockway August 23, 2022 22:26
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #8113 (ce701e2) into master (dd4b95b) will increase coverage by 20.62%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #8113       +/-   ##
===========================================
+ Coverage    1.66%   22.28%   +20.62%     
===========================================
  Files         172      424      +252     
  Lines       70883   112020    +41137     
===========================================
+ Hits         1182    24969    +23787     
- Misses      69601    82768    +13167     
- Partials      100     4283     +4183     
Impacted Files Coverage Δ
src/internal/pfsload/client.go 100.00% <0.00%> (ø)
src/internal/pachd/s3.go 0.00% <0.00%> (ø)
src/server/pfs/server/commit_store.go 79.13% <0.00%> (ø)
src/internal/storage/fileset/metadata_store.go 100.00% <0.00%> (ø)
src/server/auth/server/util.go 0.00% <0.00%> (ø)
src/internal/storage/fileset/util.go 80.45% <0.00%> (ø)
src/server/auth/server/oidc.go 0.00% <0.00%> (ø)
src/internal/pfsload/worker.go 65.21% <0.00%> (ø)
src/server/pfs/fuse/server.go 0.00% <0.00%> (ø)
src/server/identity/server/dex_api.go 83.01% <0.00%> (ø)
... and 378 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acohen4 acohen4 merged commit 049b287 into master Aug 25, 2022
@acohen4 acohen4 deleted the acohen4/helm-upgrade-no-op branch August 25, 2022 16:42
acohen4 added a commit that referenced this pull request Aug 25, 2022
…ing pods to consume new secrets. This is a stop gap until we migrate secrets to volumes, and watch their inodes to restart (#8113)
acohen4 added a commit that referenced this pull request Aug 25, 2022
…ing pods to consume new secrets. This is a stop gap until we migrate secrets to volumes, and watch their inodes to restart (#8113) (#8118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants