Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce UPGRADE_NO_OP (#8113) #8118

Merged
merged 1 commit into from Aug 25, 2022
Merged

Conversation

acohen4
Copy link
Contributor

@acohen4 acohen4 commented Aug 25, 2022

env-var to ease 'helm upgrade' auto-restarting pods to consume new secrets. This is a stop gap until we migrate secrets to volumes, and watch their inodes to restart (#8113)

…ing pods to consume new secrets. This is a stop gap until we migrate secrets to volumes, and watch their inodes to restart (#8113)
@acohen4 acohen4 requested a review from jrockway August 25, 2022 16:44
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #8118 (5767450) into 2.3.x (6b423ae) will decrease coverage by 18.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            2.3.x   #8118       +/-   ##
==========================================
- Coverage   22.28%   3.45%   -18.84%     
==========================================
  Files         415     201      -214     
  Lines      112171   74136    -38035     
==========================================
- Hits        24995    2559    -22436     
+ Misses      82900   71216    -11684     
+ Partials     4276     361     -3915     
Impacted Files Coverage Δ
src/server/auth/db.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/watch/op.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/miscutil/log.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/miscutil/math.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/grpcutil/error.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/randutil/unique.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/testutil/naming.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/storage/fileset/metadata_store.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/storage/track/tracker.go 3.70% <0.00%> (-96.30%) ⬇️
src/internal/task/etcd_queue.go 0.00% <0.00%> (-93.55%) ⬇️
... and 362 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acohen4 acohen4 merged commit 80aee4e into 2.3.x Aug 25, 2022
@acohen4 acohen4 deleted the acohen4/2_3-helm-upgrade-noop branch August 25, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants