[Jupyter] Prevent a bad config from being stored #9711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonenfant
added a commit
that referenced
this pull request
Feb 22, 2024
When handling `PUT /config` the backend was setting the config and then testing it. Now we test the new config and store it only if the config is _not_ invalid. Doing so prevents a user from inputting a bad pachd_address on the config screen and having the UI present it like it's a valid address. Surprisingly this didn't require and front end changes.
bbonenfant
added a commit
that referenced
this pull request
Feb 23, 2024
- Lumino tabs (#9692) - Uninstantiated python client bugfix (#9705) - Prevent bad config from being stored (#9711) - Remove dev_server (#9713) - UNKNOWN cluster status state (#9719) - Prevent error popups bugfix (#9721) - Infinite scroll in file explorer (#9715) - Fix local cypress tests (#9728) - Infinite scroll w/ scrollbar (#9746) - Clear mounted datums before new datums (#9716) - Make input spec non-resizeable (#9720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling
PUT /configthe backend was setting the config and then testing it. Now we test the new config and store it only if the config is not invalid. Doing so prevents a user from inputting a bad pachd_address on the config screen and having the UI present it like it's a valid address. Surprisingly this didn't require and front end changes.Jira: INT-1182