Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INT-1207] Fix local cypress tests for Arch Linux VM Dev Env #9728

Merged
merged 2 commits into from Feb 14, 2024
Merged

[INT-1207] Fix local cypress tests for Arch Linux VM Dev Env #9728

merged 2 commits into from Feb 14, 2024

Conversation

emmajsadams
Copy link
Contributor

Local cypress tests do not run in a local Arch linux vm which is our preferred development environment people will be onboarded into.

I just updated cypress up to the version that adds ARM support. I tried updating it to the current version, but ended up in a situation where due to peerDependencies would have had to update most packages in the repo. Probably worth doing, but maybe in a separate PR. I did have a few other packages I had to upgrade as a result of upgrading cypress.

I also noticed mkdirp is not being used so I removed it.

@emmajsadams
Squashed commit of the following:
4a95a87 
commit 2b19bde
Author: Emma Adams <emma.adams@hpe.com>
Date:   Tue Feb 13 17:16:04 2024 +0000

    Update url for github

commit 4d0fe7b
Author: Emma Adams <emma.adams@hpe.com>
Date:   Tue Feb 13 17:01:12 2024 +0000

    Add back svgr/cli and upgrade yaml

commit d6a93c3
Author: Emma Adams <emma.adams@hpe.com>
Date:   Tue Feb 13 16:53:27 2024 +0000

    Upgrade rimraf

commit 8c9f530
Author: Emma Adams <emma.adams@hpe.com>
Date:   Tue Feb 13 05:18:40 2024 +0000

    Update cypress version hardcoded in main.yml

commit 727344e
Author: Emma Adams <emma.adams@hpe.com>
Date:   Tue Feb 13 04:56:30 2024 +0000

    Update cypress

commit 60965e0
Author: Emma Adams <emma.adams@hpe.com>
Date:   Tue Feb 13 04:47:16 2024 +0000

    Revert setupTests change

commit c0413b1
Author: Emma Adams <emma.adams@hpe.com>
Date:   Tue Feb 13 04:46:57 2024 +0000

    Squashed commit of the following:

    commit 7898bf5
    Author: Emma Adams <emma.adams@hpe.com>
    Date:   Tue Feb 13 04:43:04 2024 +0000

        Upgrade cypress to 10.11 first version with linux support

    commit d73b7a5
    Author: Emma Adams <emma.adams@hpe.com>
    Date:   Tue Feb 13 04:39:37 2024 +0000

        Revert many package.json changes

    commit 4fd992b
    Author: Emma Adams <emma.adams@hpe.com>
    Date:   Tue Feb 13 04:22:19 2024 +0000

        Run eslint

    commit 58391e2
    Author: Emma Adams <emma.adams@hpe.com>
    Date:   Tue Feb 13 04:08:52 2024 +0000

        Update all packages

    commit 8d99d4b
    Author: Emma Adams <emma.adams@hpe.com>
    Date:   Tue Feb 13 03:28:37 2024 +0000

        Squashed commit of the following:

        commit ead49d0
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Tue Feb 13 03:22:50 2024 +0000

            Complete clean install of package-lock

        commit c2fd653
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Tue Feb 13 03:10:58 2024 +0000

            Update package-lock without force dependencies

        commit 76ca75e
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Tue Feb 13 03:04:47 2024 +0000

            Add specific cypress version

        commit c235d3e
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Tue Feb 13 02:57:21 2024 +0000

            Revert nvmrc

        commit 72d91e6
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Tue Feb 13 02:03:25 2024 +0000

            Try force resolutions

        commit ae9fec2
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Tue Feb 13 01:54:05 2024 +0000

            Update nvm and package.json

        commit 2985fac
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Tue Feb 13 01:30:49 2024 +0000

            Use ^13.0.0

        commit 0d0ee16
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Tue Feb 13 01:07:36 2024 +0000

            Unskip specs
            Remove unnecessary video:true
            Add test:ci
            Remove unnecessary index.js

        commit 023ea45
        Author: Emma Adams <emma.adams@hpe.com>
        Date:   Mon Feb 12 21:16:01 2024 +0000

            Upgrade cypress and migrate tets
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (321ed10) 59.37% compared to head (c628b71) 59.36%.
Report is 9 commits behind head on master.

Files Patch % Lines
src/internal/migrations/migrations.go 75.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9728      +/-   ##
==========================================
- Coverage   59.37%   59.36%   -0.02%     
==========================================
  Files         583      583              
  Lines       71133    71139       +6     
==========================================
- Hits        42238    42233       -5     
  Misses      28278    28278              
- Partials      617      628      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmajsadams emmajsadams merged commit 4532a72 into master Feb 14, 2024
33 checks passed
bbonenfant pushed a commit that referenced this pull request Feb 22, 2024
@emmajsadams @bbonenfant
[INT-1207] Fix local cypress tests for Arch Linux VM Dev Env (#9728)
4160451 
Local cypress tests do not run in a local Arch linux vm which is our
preferred development environment people will be onboarded into.

I just updated cypress up to the version that adds ARM support. I tried
updating it to the current version, but ended up in a situation where
due to peerDependencies would have had to update most packages in the
repo. Probably worth doing, but maybe in a separate PR. I did have a few
other packages I had to upgrade as a result of upgrading cypress.

I also noticed `mkdirp` is not being used so I removed it.
bbonenfant added a commit that referenced this pull request Feb 23, 2024
@bbonenfant
[Jupyter] Bulk 2.9.x backport (#9765)
75471af 
- Lumino tabs (#9692)
- Uninstantiated python client bugfix (#9705)
- Prevent bad config from being stored (#9711)
- Remove dev_server (#9713)
- UNKNOWN cluster status state (#9719)
- Prevent error popups bugfix (#9721)
- Infinite scroll in file explorer (#9715)
- Fix local cypress tests (#9728)
- Infinite scroll w/ scrollbar (#9746)
- Clear mounted datums before new datums (#9716)
- Make input spec non-resizeable (#9720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbonenfant bbonenfant bbonenfant approved these changes

Assignees

@bbonenfant bbonenfant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emmajsadams @bbonenfant