[Jupyter] Remove dev_server from tests #9713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9713 +/- ##
==========================================
- Coverage 58.98% 58.96% -0.02%
==========================================
Files 583 583
Lines 71133 71133
==========================================
- Hits 41956 41946 -10
- Misses 28550 28555 +5
- Partials 627 632 +5 ☔ View full report in Codecov by Sentry. |
kevyang
approved these changes
Feb 7, 2024
bbonenfant
added a commit
that referenced
this pull request
Feb 22, 2024
I converted all the tests away from using the dev_server fixture and removed the fixture. Additionally: * I added back in the python tests that were skipped because of the missing chunk errors. Doing so required a couple of changes to the names of the resources within the tests. * I updated the download code a bit to download to the jupyter's `root_dir` as opposed to the cwd of the server. I think the "correct" approach anyways, since you can configure which directory the jupyter server serves files from, but it also has the added benefit of allowing us to configure this value during the test so that we can write files to a temp directory. The way this test was written, you needed to delete the downloaded files before running the test again. * I also split up the config and pps/publish tests to their own files.
bbonenfant
added a commit
that referenced
this pull request
Feb 23, 2024
- Lumino tabs (#9692) - Uninstantiated python client bugfix (#9705) - Prevent bad config from being stored (#9711) - Remove dev_server (#9713) - UNKNOWN cluster status state (#9719) - Prevent error popups bugfix (#9721) - Infinite scroll in file explorer (#9715) - Fix local cypress tests (#9728) - Infinite scroll w/ scrollbar (#9746) - Clear mounted datums before new datums (#9716) - Make input spec non-resizeable (#9720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted all the tests away from using the dev_server fixture and removed the fixture.
Additionally:
root_diras opposed to the cwd of the server. I think the "correct" approach anyways, since you can configure which directory the jupyter server serves files from, but it also has the added benefit of allowing us to configure this value during the test so that we can write files to a temp directory. The way this test was written, you needed to delete the downloaded files before running the test again.