bisect_insert_strategy doesn't accumulate results

[jameshiebert]

Just did a run of the moti_insert and found an interesting result:

{"asctime": "2018-08-24 14:59:20,814", "levelname": "INFO", "name": "crmprtd.insert", "message": "Using Chunk + Bisection Strategy"}
{"asctime": "2018-08-24 14:59:21,111", "levelname": "INFO", "name": "crmprtd.insert", "message": "Successfully inserted observations", "num_obs": 512}
{"asctime": "2018-08-24 14:59:21,187", "levelname": "INFO", "name": "crmprtd.insert", "message": "Successfully inserted observations", "num_obs": 128}
{"asctime": "2018-08-24 14:59:21,209", "levelname": "INFO", "name": "crmprtd.insert", "message": "Successfully inserted observations", "num_obs": 32}
{"asctime": "2018-08-24 14:59:21,224", "levelname": "INFO", "name": "crmprtd.insert", "message": "Successfully inserted observations", "num_obs": 16}
{"asctime": "2018-08-24 14:59:21,230", "levelname": "INFO", "name": "crmprtd.insert", "message": "Successfully inserted observations", "num_obs": 2}
{"asctime": "2018-08-24 14:59:21,234", "levelname": "INFO", "name": "crmprtd.insert", "message": "Data insertion complete"}
{"asctime": "2018-08-24 14:59:21,235", "levelname": "INFO", "name": "crmprtd", "message": "Data insertion results", "results": {"insertions_per_sec": 4.76, "skips": 0, "successes": 2, "failures": 0}}

As you can see, the end "result" is 2 successful insertions, even though the logs show that it's successfully inserting larger chunks before that. If you look at the code:

        with Timer() as tmr:
            for chunk in chunks(observations):
                dbm = bisect_insert_strategy(sesh, chunk)

You have forgotten to accumulate the results from each chunk insert, throwing away the results from before. This should be a quick fix:

dbm += bisect_insert_strategy(sesh, chunk)

As long as dbm is initialized prior to the beginning of the loop.

[jameshiebert]

You probably know this already, but the issue is only in the dev branch :)

[nikola-rados]

During my testing today I discovered the same issue and fixed it in a commit. Have not pushed the change yet though until I finish testing all the networks.