Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with test data variables OR with variable_tags #189

Open
rod-glover opened this issue Dec 15, 2023 · 0 comments
Open

Problem with test data variables OR with variable_tags #189

rod-glover opened this issue Dec 15, 2023 · 0 comments

Comments

@rod-glover
Copy link
Contributor

At present, we have the following two things:

  1. Function variable_tags detects climatological variables based on the following criterion: net_var_name ~ 'Climatology'.
  2. Test dataset data/crmp_subset_data.sql defines a large number of variables which meet one or both of the following conditions:
    • long_description includes the phrase "Climatological mean"
    • tests (which I don't trust even in their original form) embodied in pdp_util, classify them as climatological

Item (1) was the result of examining all variables currently in CRMP and observing that their names, sensibly enough, met that criterion.

Item (2) is legacy.

We should fix this. Given that (1) seems to be a functional way to do things for now, at least, and (2) hails very far back, I suggest that we fix the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant