Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating selected watershed does not update graphs #38

Closed
corviday opened this issue Jul 13, 2023 · 0 comments · Fixed by #52
Closed

updating selected watershed does not update graphs #38

corviday opened this issue Jul 13, 2023 · 0 comments · Fixed by #52
Labels
bug Something isn't working

Comments

@corviday
Copy link
Collaborator

corviday commented Jul 13, 2023

To reproduce:

  • Select a watershed from the region dropdown below map
  • select a variable on the "Yearly Indicators" tab
  • wait for the graph to load
  • select a different watershed on the region dropdown
  • graph won't update!

This holds true for the other graph tabs as well.

A bit puzzling - the salmon population tables do update, so the issue does not seem to be that DataDisplay is not passing updated regions to its children correctly - graphs and tables are all children of DataDisplay. Check react hooks for correct usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant