Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranges IsInside logical error #12

Closed
GoogleCodeExporter opened this issue Jul 14, 2015 · 4 comments
Closed

Ranges IsInside logical error #12

GoogleCodeExporter opened this issue Jul 14, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

In DoubleRange.cs and IntegerRange.cs, I think the IsInside function is in
error; Don't really know how it affect the code and examples, I'm just
starting to look at it !

Original:
public bool IsInside( double x )
{
  return ( ( x >= min ) && ( x <= min ) ); // This looks like return x == min
}

Should be (?) :
  return ( ( x >= min ) && ( x <= max ) );

Original issue reported on code.google.com by martinmiller@gmail.com on 22 Jan 2007 at 2:14

@GoogleCodeExporter
Copy link
Author

Ups. Mistyped. This method was not used yet in the library, so that is why the 
error 
was not spotted.

Original comment by andrew.k...@gmail.com on 22 Jan 2007 at 8:02

  • Changed state: Fixed
  • Added labels: Project-Core

@GoogleCodeExporter
Copy link
Author

Good !

Also, As was studying the code I'm not sure about the IsInside "definition" and 
IsOverlaping "definition"; I find them not as good as "intersect" and "subset", 
as 
used in Set theory ( http://en.wikipedia.org/wiki/Set )

But I'm just nitpicking ;-)

Original comment by martinmiller@gmail.com on 22 Jan 2007 at 2:35

@GoogleCodeExporter
Copy link
Author

Original comment by andrew.k...@gmail.com on 26 Aug 2007 at 6:34

  • Changed state: Verified

@GoogleCodeExporter
Copy link
Author

Original comment by andrew.k...@gmail.com on 19 May 2008 at 6:08

  • Changed state: Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant