Make ROLLBAR_TOKEN optional, provide PACKET_ var name alternatives | ENG-7652 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
requested changes
Jul 30, 2020
splaspood
force-pushed
the
ENG-7652
branch
2 times, most recently
from
d21c584
to
b2d0da5
Compare
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 74.55% 74.85% +0.30%
==========================================
Files 5 5
Lines 334 338 +4
==========================================
+ Hits 249 253 +4
Misses 71 71
Partials 14 14
Continue to review full report at Codecov.
|
splaspood
force-pushed
the
ENG-7652
branch
2 times, most recently
from
3557e89
to
ecbd39a
Compare
splaspood
changed the title
mmlb
requested changes
Jul 31, 2020
splaspood
force-pushed
the
ENG-7652
branch
4 times, most recently
from
b1e0f24
to
d092caa
Compare
mmlb
previously approved these changes
Aug 3, 2020
DavidHwu
previously approved these changes
Aug 3, 2020
Since the 'tinkerbell' suite is no longer solely utilized by Packet/Equinix, it stands to reason not every user/deployment will wish to integrate with rollbar for exception logging. This change makes the rollbar integration optional. Additionally the example log function tests were moved to their own file.
codecov isn't used as a blocking check, at the moment its used to see if coverage goes down and to try to figure out why. |
mmlb
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the 'tinkerbell' suite is no longer solely utilized by Packet/Equinix, it
stands to reason not every user/deployment will wish to integrate with rollbar
for exception logging. This change makes the rollbar integration optional.
Additionally we provide alternative env var names for PACKET_VERSION and PACKET_ENV (VERSION and ENV respectively). These env vars are only required if ROLLBAR_TOKEN is defined.