Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user's permissions on Issues/PRs #100

Open
7 tasks
marusinm opened this issue Jul 5, 2019 · 5 comments
Open
7 tasks

user's permissions on Issues/PRs #100

marusinm opened this issue Jul 5, 2019 · 5 comments
Assignees
Labels
area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. good-first-issue Good for newcomers. Hacktoberfest Participate in https://hacktoberfest.digitalocean.com kind/feature New feature or a request for enhancement. kind/refactor Technical debt - the code needs love. pagure Related to Pagure implementation. pinned Ignored by stale-bot. triaged This issue was already processed by the team.

Comments

@marusinm
Copy link
Contributor

marusinm commented Jul 5, 2019

Updated by @lachmanfrantisek :

We have a lot of methods related to the permissions (e.g. who can merge/close,..)

It's not consistent, let's clean that!

Feel free to solve this in smaller parts. Just write on what you are going to work...

AC:

The progress is tracked in the following tables. (Any update in the comments is appreciated.)

Project who_can_close_issue() -> Set[str] who_can_merge_pr() -> Set[str] can_close_issue(username: str) -> bool can_merge_pr(username: str) -> bool
abstract 👍 👍 ❗ deprecate the Issue argument
base nothing nothing implement here implement here
Github ? ? ? ?
GitLab ? ? ? ?
Pagure ? ? ? ?
Issue who_can_close() -> Set[str] can_close(username: str) -> bool
abstract implement here 👍
base nothing 👍
Github ? nothing
GitLab ? nothing
Pagure ? nothing
PullRequest who_can_close() -> Set[str] who_can_merge() -> Set[str] can_close(username: str) -> bool can_merge(username: str) -> bool
abstract ? ? ? ?
base nothing nothing implement here implement here
Github ? ? ? ?
GitLab ? ? ? ?
Pagure ? ? ? ?
@lachmanfrantisek lachmanfrantisek added kind/feature New feature or a request for enhancement. area/github Related to GitHub implementation. pagure Related to Pagure implementation. triaged This issue was already processed by the team. labels Jul 10, 2019
@lachmanfrantisek

This comment has been minimized.

@lachmanfrantisek lachmanfrantisek added area/gitlab Related to GitLab implementation. and removed area/github Related to GitHub implementation. pagure Related to Pagure implementation. labels Sep 18, 2019
@lachmanfrantisek lachmanfrantisek removed the triaged This issue was already processed by the team. label Nov 1, 2019
@stale

This comment has been minimized.

@stale stale bot added the stale Is the issue still valid? label Dec 31, 2019
@lachmanfrantisek

This comment has been minimized.

@stale stale bot removed the stale Is the issue still valid? label Jan 2, 2020
@lachmanfrantisek lachmanfrantisek added area/github Related to GitHub implementation. good-first-issue Good for newcomers. pagure Related to Pagure implementation. labels Feb 14, 2020
@lachmanfrantisek
Copy link
Member

I've updated the description. This issue is now about cleaning the methods and add the missing parts. Please, check if I don't forget anything.

@lachmanfrantisek lachmanfrantisek added the kind/refactor Technical debt - the code needs love. label Feb 14, 2020
@jpopelka jpopelka added the triaged This issue was already processed by the team. label Mar 27, 2020
@stale

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. good-first-issue Good for newcomers. Hacktoberfest Participate in https://hacktoberfest.digitalocean.com kind/feature New feature or a request for enhancement. kind/refactor Technical debt - the code needs love. pagure Related to Pagure implementation. pinned Ignored by stale-bot. triaged This issue was already processed by the team.
Projects
Status: backlog
Development

No branches or pull requests

4 participants