Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LocalProbjectBuilder instead of old LocalProject constructor #1955

Closed
Tracked by #343
FrNecas opened this issue Mar 9, 2023 · 0 comments · Fixed by #2449
Closed
Tracked by #343

Use LocalProbjectBuilder instead of old LocalProject constructor #1955

FrNecas opened this issue Mar 9, 2023 · 0 comments · Fixed by #2449
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. kind/refactor Technical debt - the code needs love.

Comments

@FrNecas
Copy link

FrNecas commented Mar 9, 2023 •
edited by jpopelka
Loading

Follow-up to packit/packit#1558

The old usages should be removed, tests updated. Inspiration can be taken from adjustments in Packit CLI in the linked PR

Also consider if there are not unnecessary arguments/attributes in the API in the new class, e.g. we were debating whether remote and pr_id and similar still make sense.

EDIT [Jirka]: FYI, hardly code should be updated in packit/hardly#92
This was referenced Mar 9, 2023
Open
Open
@nforro nforro added kind/refactor Technical debt - the code needs love. complexity/single-task Regular task, should be done within days. area/general Related to whole service, not a specific part/integration. labels Apr 22, 2024
@lbarcziova lbarcziova mentioned this issue May 30, 2024
Closed
4 tasks
@lbarcziova lbarcziova mentioned this issue Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. kind/refactor Technical debt - the code needs love.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Utilise LocalProjectBuilder for LP initalisation lbarcziova/packit-service
2 participants
@nforro @FrNecas