chore: allow v3 matchers in message metadata

Fixes #1133
pact-foundation · Feb 28, 2024 · 3fcd919 · 3fcd919
1 parent 3ac5e0c
commit 3fcd919
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 23 deletions.
diff --git a/examples/messages/consumer/message-consumer.spec.ts b/examples/messages/consumer/message-consumer.spec.ts
@@ -35,7 +35,7 @@ describe('Message consumer tests', () => {
           }),
         })
         .withMetadata({
-          queue: 'animals',
+          queue: like('animals'),
         })
         .verify(synchronousBodyHandler(dogApiHandler));
     });
@@ -53,7 +53,7 @@ describe('Message consumer tests', () => {
           }),
         })
         .withMetadata({
-          queue: 'animals',
+          queue: like('animals'),
         })
         .verify(synchronousBodyHandler(dogApiHandler));
     });

diff --git a/examples/messages/package-lock.json b/examples/messages/package-lock.json
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -95,7 +95,7 @@
     ]
   },
   "dependencies": {
-    "@pact-foundation/pact-core": "^14.1.1",
+    "@pact-foundation/pact-core": "^14.3.0",
     "@types/express": "^4.17.11",
     "axios": "^1.6.1",
     "body-parser": "^1.20.0",

diff --git a/src/dsl/matchers.ts b/src/dsl/matchers.ts
@@ -40,7 +40,7 @@ export interface ArrayMatcher<T> extends Matcher<T> {
   max?: number;
 }
 
-export function isMatcher(x: AnyTemplate): x is Matcher<AnyTemplate> {
+export function isMatcher(x: unknown): x is Matcher<AnyTemplate> {
   return x != null && (x as Matcher<AnyTemplate>).getValue !== undefined;
 }
 

diff --git a/src/dsl/message.ts b/src/dsl/message.ts
@@ -1,5 +1,6 @@
 import { AnyJson } from '../common/jsonTypes';
 import { Matcher } from './matchers';
+import { Matcher as MatcherV3 } from '../v3/matchers';
 
 /**
  * Metadata is a map containing message context,
@@ -8,7 +9,7 @@ import { Matcher } from './matchers';
  * @module Message
  */
 export interface Metadata {
-  [name: string]: string | Matcher<string>;
+  [name: string]: string | Matcher<string> | MatcherV3<string>;
 }
 
 /**

diff --git a/src/messageConsumerPact.ts b/src/messageConsumerPact.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-nested-ternary */
 /**
  * @module Message
  */
@@ -23,6 +24,7 @@ import ConfigurationError from './errors/configurationError';
 import { version as pactPackageVersion } from '../package.json';
 import { numberToSpec } from './common/spec';
 import { SpecificationVersion } from './v3';
+import { isMatcher } from './dsl/matchers';
 
 const DEFAULT_PACT_DIR = './pacts';
 
@@ -169,10 +171,7 @@ export class MessageConsumerPact {
     }
 
     forEachObjIndexed((v, k) => {
-      this.message.withMetadata(
-        `${k}`,
-        typeof v === 'string' ? v : v.getValue()
-      );
+      this.message.withMetadata(`${k}`, JSON.stringify(v));
     }, metadata);
 
     return this;

diff --git a/src/v4/message/index.ts b/src/v4/message/index.ts
@@ -28,6 +28,7 @@ import {
   generateMockServerError,
 } from '../../v3/display';
 import logger from '../../common/logger';
+import { isMatcher as isV3Matcher } from '../../v3/matchers';
 
 const defaultPactDir = './pacts';
 
@@ -188,10 +189,7 @@ export class SynchronousMessageWithResponseBuilder
     }
 
     forEachObjIndexed((v, k) => {
-      this.interaction.withMetadata(
-        `${k}`,
-        typeof v === 'string' ? v : v.getValue()
-      );
+      this.interaction.withMetadata(`${k}`, JSON.stringify(v));
     }, metadata);
 
     return this;