Skip to content

Commit

Permalink
chore(docs): update comment on Jest integration #10
Browse files Browse the repository at this point in the history
  • Loading branch information
mefellows committed Jan 21, 2017
1 parent 2374a31 commit 6f9064e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ npm install --save-dev pact
* [Pact with Karma + Mocha](https://github.com/pact-foundation/pact-js/tree/master/karma/mocha)

#### Note on Jest
Jest uses JSDOM under the hood which may cause weird issues with libraries making HTTP request. Check [this issue](https://github.com/pact-foundation/pact-js/issues/10) and more explicitly [this comment](https://github.com/pact-foundation/pact-js/issues/10#issuecomment-249356066) about that.
Jest uses JSDOM under the hood which may cause issues with libraries making HTTP request. See [this issue](https://github.com/pact-foundation/pact-js/issues/10) for background,
and the Jest [example](https://github.com/pact-foundation/pact-js/blob/master/examples/jest/package.json#L10-L12) for a working solution.

### Using Pact JS

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pact",
"version": "1.0.0-rc.5",
"version": "1.0.0",
"description": "Pact for all things Javascript",
"main": "./src/pact.js",
"scripts": {
Expand Down

0 comments on commit 6f9064e

Please sign in to comment.