Diagrams in messages document are not rendered

[tienvx]

Software versions

NA

Issue Checklist

NA

Expected behaviour

Diagrams should be rendered

Actual behaviour

Diagrams are not rendered

Steps to reproduce

• Open https://docs.pact.io/implementation_guides/javascript/docs/messages
• Go to Contract Testing Process (Async) section
• There are 2 diagrams in that section that are not rendered

Relevant log files

NA

[rubemfsv]

@mefellows I just resolved here: #1119

[rubemfsv]

Resolved and merged #1119
@YOU54F I think it is interesting to close this issue then. Thanks!

[YOU54F]

Not quite just yet unfortunately 😓

1. we need to check it renders on the site to close this issue
2. is isn't actually rendering on the site post the update https://docs.pact.io/implementation_guides/javascript/docs/messages

it's unrelated to your change, but related to the docs sync job, which appears to require ?raw=true for the images to render

pact-foundation/docs.pact.io@b4a393b#diff-dd41eeae0d557ea0bd62cbcb2548f88613902e11ed50f3d0d90b547494a129ccL23

See related issue here

pact-foundation/docs.pact.io#265 (comment)

[YOU54F]

I think the links just need to be raw githubusercontent links, ie

https://raw.githubusercontent.com/pact-foundation/pact-js/master/docs/diagrams/message-provider.png

which would resolve it on the site, and when viewed on the repo