Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No indication of port being in use during provider.setup() call? #37

Closed
screamish opened this issue Apr 11, 2017 · 2 comments
Closed

No indication of port being in use during provider.setup() call? #37

screamish opened this issue Apr 11, 2017 · 2 comments
Assignees
@mefellows
Projects
Pact JS Roadmap

Comments

@screamish
Copy link
Contributor

screamish commented Apr 11, 2017 •
edited by mefellows

I just spent a good while being a doofus getting started with pact-js in a new project (been a PACT user for a fair while) all because the port I chose for my provider (8081) was in use. Yes, my silly choice of port (if only I'd thought to run an lsof hours ago and save myself much wasted time), but I'm just wondering why this didn't result in error messages back from provider.setup() or even anything in the debug level logs to console?
@mefellows mefellows self-assigned this Apr 11, 2017
@mefellows
Copy link
Member

Thanks @screamish - seems like a nice UX addition!

mefellows added a commit that referenced this issue Apr 16, 2017
@mefellows
feat(port-check): check if port is available during setup() #37
14d66c6
@mefellows mefellows mentioned this issue Apr 16, 2017
Merged
mefellows added a commit that referenced this issue Apr 16, 2017
@mefellows
feat(port-check): check if port is available during setup() #37
259e016
mefellows added a commit that referenced this issue Apr 16, 2017
@mefellows
feat(port-check): check if port is available during setup() #37
93c01c2
mefellows added a commit that referenced this issue Apr 16, 2017
@mefellows
feat(port-check): check if port is available during setup() #37
1f26a99
mefellows added a commit that referenced this issue Apr 16, 2017
@mefellows
feat(port-check): check if port is available during setup() #37
d8653c3
mefellows added a commit that referenced this issue Apr 16, 2017
@mefellows
feat(port-check): check if port is available during setup() #37
c729d8e
mefellows added a commit that referenced this issue Apr 16, 2017
@mefellows
Merge pull request #42 from pact-foundation/feat/port-check
06fd385 
feat(port-check): check if port is available during setup() #37
@mefellows
Copy link
Member

Latest build released to https://www.npmjs.com/package/pact (v2.3.2).

For future me, I wasn't able to repro the Karma issue in the builds until I ran npm run dist. This was the cause of the multiple git push -f.

Thanks @screamish :)

@mefellows mefellows added this to Done in Pact JS Roadmap May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mefellows mefellows

Labels
None yet
Projects
Pact JS Roadmap
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mefellows @screamish