Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC1123 Datetime matcher format #451

Closed
tomasbasham opened this issue May 5, 2020 · 3 comments
Closed

RFC1123 Datetime matcher format #451

tomasbasham opened this issue May 5, 2020 · 3 comments

Comments

@tomasbasham
Copy link

From the look of the regex I believe this is actually a RFC1123 datetime format and not RFC3339.

export const RFC3339_TIMESTAMP_FORMAT =

@TimothyJones
Copy link
Contributor

From a cursory glance it appears you are correct.

Before I go unpacking the regex, do you happen to know that it is wholly RFC1123 compliant, or were you just reporting that it looks like it probably is RFC1123?

Either way, thanks for the report! Much appreciated.

@tomasbasham
Copy link
Author

I'm afraid I'm not too familiar with the standard. I just noticed it most definitely was not RFC3339 as this is used a lot in Go.

TimothyJones added a commit that referenced this issue Sep 14, 2021
BREAKING CHANGE: `Matchers.rfc3339Timestamp()` has been renamed to `Matchers.rfc1123Timestamp()`. The behaviour is unchanged - it was always RFC1123, and never did match RFC3339 timestamps.
@TimothyJones
Copy link
Contributor

Thanks for the report! This is fixed in v10.0.0-beta.47, and will be in the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants