Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] posibility to increase Provider state callback timeout #600

Closed
2 tasks done
individual-it opened this issue Feb 8, 2021 · 6 comments
Closed
2 tasks done

[V3] posibility to increase Provider state callback timeout #600

individual-it opened this issue Feb 8, 2021 · 6 comments
Assignees

Comments

@individual-it
Copy link
Contributor

Checklist

Before making a feature request, I have:

Feature description

The timeout for setting states seems to be fixed to 1000ms it would be great to be able to increase that timeout

Use case

depending on the provider, the state that need to be set and the hardware it might take longer than 1sec to set the state e.g when cleaning up or resetting a provider

@individual-it
Copy link
Contributor Author

If I'm not wrong that was implemented by @rholshausen for pact-reference in pact-foundation/pact-reference@4afa86a

@individual-it
Copy link
Contributor Author

looks like there is work done in this issue before I've even created it e.g. 727968c 👍

so just waiting for the next release 💤

@uglyog
Copy link
Member

uglyog commented Feb 8, 2021

Still need someone to do this bit:

            // TODO: add this in once the downstream lib has been released
            // timeout: self.options.callback_timeout

Hopefully @mefellows does it :-D

@individual-it
Copy link
Contributor Author

@uglyog the current master of pact-js already helps because it has 10sec timeout hardcoded ;-)

@mefellows mefellows self-assigned this Feb 8, 2021
@mefellows
Copy link
Member

On it. I'll have this flag in the next release (tonight, assuming I don't mess up the release step).

mefellows added a commit that referenced this issue Feb 8, 2021
- Adds overwrite flag to consumer tests to control pact write behaviour
- Adds callbackTimeout on provider side to control provider states and
request filter execution timeout
- Fixes file locking issues #599
- Fixes #600
@individual-it
Copy link
Contributor Author

fixed by e891fcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants