fix: Add support for state params to MessageProviderPact (#372) #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mefellows
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Thanks!
FWIW this is still in the V2 part of the code base and I'm not actually sure that the core (Ruby) fully supports parameters.
The work in the new pact-core module exposes methods to do message based tests, but this code path still uses the Ruby core.
I'm not sure yet if this should stay backwards compatible with the previous Ruby core and have a new message interface exposed for the V3. But I'll bring this in for now and see how we go.
TimothyJones
added a commit
to TimothyJones/pact-js
that referenced
this pull request
Feb 16, 2023
…lers` from `StateHandlers` avoiding the conflicting type problem introduced in pact-foundation#882. Fixes pact-foundation#1057
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing the params of providerStates to the
stateHandlersof aMessageProviderPact.