Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for state params to MessageProviderPact (#372) #882

Merged
merged 1 commit into from Jul 1, 2022

Conversation

MichaelTamm
Copy link
Contributor

This PR adds support for passing the params of providerStates to the stateHandlers of a MessageProviderPact.

Copy link
Member

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

FWIW this is still in the V2 part of the code base and I'm not actually sure that the core (Ruby) fully supports parameters.

The work in the new pact-core module exposes methods to do message based tests, but this code path still uses the Ruby core.

I'm not sure yet if this should stay backwards compatible with the previous Ruby core and have a new message interface exposed for the V3. But I'll bring this in for now and see how we go.

@mefellows mefellows merged commit 33c145a into pact-foundation:feat/v3.0.0 Jul 1, 2022
TimothyJones added a commit to TimothyJones/pact-js that referenced this pull request Feb 16, 2023
…lers` from `StateHandlers` avoiding the conflicting type problem introduced in pact-foundation#882. Fixes pact-foundation#1057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants