Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Message link in messages examples README #1097

Merged
merged 1 commit into from Jun 29, 2023

Conversation

mcalthrop
Copy link
Contributor

@mcalthrop mcalthrop commented Jun 29, 2023

Fixed the link to the Message object in the messages examples README was incorrect.

Please note: to test this PR, I ran the following commands:

npm install
npm run dist

This resulted in an error:
Screenshot 2023-06-29 at 09 23 55

So I ran this command:

ENABLE_FEATURE_V4=true npm run dist

And that command succeeded.

@mcalthrop mcalthrop changed the title fix: message link error in messages examples README docs: fix Message link in messages examples README Jun 29, 2023
@mcalthrop mcalthrop marked this pull request as ready for review June 29, 2023 08:26
@mefellows
Copy link
Member

Thanks, great spot - that needs to be updated. I'll get that sorted next week - thanks for the PR!

@mefellows mefellows merged commit bff5a44 into pact-foundation:master Jun 29, 2023
5 of 8 checks passed
@mcalthrop mcalthrop deleted the patch-1 branch June 29, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants