Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not split headers by comma #1099

Merged
merged 1 commit into from Jul 10, 2023

Conversation

mefellows
Copy link
Member

@mefellows mefellows commented Jul 8, 2023

This PR reverts the change added in #1031. Multi-valued headers are supported partially, as they must be specified using the array syntax. The open issues have connected and reproduced upstream issues now, but I think we should release this sooner rather than later.

Reverts the core change in 9c7939e
Relates to #1031
Fixes #1058

chore: update debug message for headers
chore: update mocha test to use correct multi-valued header syntax
@YOU54F
Copy link
Member

YOU54F commented Jul 8, 2023

windows runners are hanging I believe on the v4 plugin provider verification. they aren't cancelling down, so locking up the orgs runners, so have cancelled the builds for now 👍🏾

@mefellows mefellows merged commit 4636617 into master Jul 10, 2023
6 of 14 checks passed
@mefellows mefellows deleted the fix/issue-1058-header-parsed-incorrectly branch July 10, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants