Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pact core dependency #1165

Closed

Conversation

miguelci
Copy link

@miguelci miguelci commented Jan 18, 2024

  • npm run dist works locally (this will run tests, lint and build)
  • Commit messages are ready to go in the changelog (see below for details)
  • PR template filled in (see below for details)

PR Template

Update the pact-core dependency to their last version.
https://github.com/pact-foundation/pact-js-core/releases/tag/v14.0.6

There was a fix on one of its updates on the fromProviderState function that might fix an issue mentioned in https://pact-foundation.slack.com/archives/C9VBGLUM9/p1705297213981799?thread_ts=1704896397.421819&cid=C9VBGLUM9

@miguelci
Copy link
Author

can someone confirm if the fails are related to some issue in the server or to the change?

@mefellows
Copy link
Member

mefellows commented Jan 18, 2024

This PR isn't really needed, as the dependency in the package.json allows patch version updates. If you need the latest, the simplest thing to do is an npm update @pact-foundation/pact in the project and you should get the latest.

can someone confirm if the fails are related to some issue in the server or to the change?

hmm that is a curious failure, I've actually never seen it before. I'll see if I can reproduce locally.

@miguelci miguelci closed this Jan 18, 2024
@miguelci miguelci deleted the update-pact-core-dependency branch January 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants